Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional Windows Image Updates #589

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Additional Windows Image Updates #589

merged 5 commits into from
Oct 31, 2023

Conversation

AndrewKahr
Copy link
Member

@AndrewKahr AndrewKahr commented Oct 29, 2023 •
edited
Loading

Changes

  • Fix Unity Pathing
  • Update tests to use windows-2022 for new images
  • Bump docker image tag
  • Bump action versions
  • Improve PR template
  • Fix workflow naming for Macos
  • Only build test project on supported Unity versions (LTS and latest tech stream)

Note: Tests will fail while images don't exist. The docker repo tests contain a representative test run of these changes here.

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make
    a PR in the documentation repo)
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@github-actions
Copy link

Cat Gif

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2023 •
edited
Loading

Codecov Report

Merging #589 (3a45df4) into main (4c4611c) will not change coverage.
The diff coverage is 50.00%.

❗ Current head 3a45df4 differs from pull request most recent head f623864. Consider uploading reports for the commit f623864 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #589   +/-   ##
=======================================
  Coverage   37.22%   37.22%           
=======================================
  Files          77       77           
  Lines        3060     3060           
  Branches      649      649           
=======================================
  Hits         1139     1139           
  Misses       1771     1771           
  Partials      150      150
Files Coverage Δ
src/model/image-tag.ts 48.88% <50.00%> (ø)

@AndrewKahr AndrewKahr merged commit 7afabe7 into main Oct 31, 2023
1 of 19 checks passed
@AndrewKahr AndrewKahr deleted the windows-image-updates branch October 31, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmfinol davidmfinol davidmfinol approved these changes

@webbertakken webbertakken Awaiting requested review from webbertakken

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrewKahr @codecov-commenter @davidmfinol